NMS MPS device wrapper #9620
Merged
NMS MPS device wrapper #9620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May resolve #9613 Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Signed-off-by: Glenn Jocher <glenn.jocher@ultralytics.com>
2 tasks
|
There's still a problem. If some tensor's are empty (no boxes) these device is not set back to mps. Resulting multiple devices. For example there should be before returning from "non_max_suppression": if mps:
output = [a.to(device) for a in output]
return output |
|
@markusuntera thanks for sharing your feedback! It sounds like you are encountering an issue with the MPS device not being set back resulting in multiple devices when some tensors are empty. It seems like adding a conditional check to return the device to MPS if it is enabled before exiting the "non_max_suppression" function could be a viable solution. Have you tested this approach? Let me know if I can assist further! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May resolve #9613
Signed-off-by: Glenn Jocher glenn.jocher@ultralytics.com
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improvement in MPS (Apple Silicon) support for Non-Maximum Suppression (NMS) in YOLOv5.
📊 Key Changes
🎯 Purpose & Impact